Skip to content

Update Android artifact naming and version to 1.2.0-SNAPSHOT#16846

Merged
kirklandsign merged 2 commits intomainfrom
copilot/update-gradle-version-to-120-snapshot
Jan 27, 2026
Merged

Update Android artifact naming and version to 1.2.0-SNAPSHOT#16846
kirklandsign merged 2 commits intomainfrom
copilot/update-gradle-version-to-120-snapshot

Conversation

Copy link
Contributor

Copilot AI commented Jan 24, 2026 •
edited
Loading

Summary

Applies artifact naming change from #16806 to main branch: treats xnnpack as the default flavor, producing executorch-android without suffix. Other flavors (e.g., qnn) retain the -<flavor> suffix. Updates default version to 1.2.0-SNAPSHOT.

Before:

coordinates(..., execuTorchVersion ?: "1.0.0-SNAPSHOT")
// flavor="xnnpack" → executorch-android-xnnpack
// flavor="qnn" → executorch-android-qnn

After:

coordinates(..., execuTorchVersion ?: "1.2.0-SNAPSHOT")
// flavor="xnnpack" → executorch-android
// flavor="qnn" → executorch-android-qnn

Test plan

Changes are to Gradle configuration only. Artifact naming will be validated through Maven Central publishing workflow.

Original prompt

Apply change in https://github.com/pytorch/executorch/pull/16806/changes extension/android/executorch_android/build.gradle to main branch. version should be 1.2.0-SNAPSHOT though.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 24, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16846

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 2 Unrelated Failures

As of commit d8251f8 with merge base 2d6c2ef (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 24, 2026
@github-actions
Copy link

github-actions bot commented Jan 24, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@kirklandsign
Apply PR #16806 changes: update coordinates logic and version to 1.2.…
d8251f8 
…0-SNAPSHOT

Co-authored-by: kirklandsign <107070759+kirklandsign@users.noreply.github.com>
Copilot AI changed the title [WIP] Update build.gradle version to 1.2.0-SNAPSHOT Update Android artifact naming and version to 1.2.0-SNAPSHOT Jan 24, 2026
Copilot AI requested a review from kirklandsign January 24, 2026 00:08
@kirklandsign kirklandsign marked this pull request as ready for review January 27, 2026 19:17
Copilot AI review requested due to automatic review settings January 27, 2026 19:17
Copilot AI reviewed Jan 27, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Android artifact naming convention to treat xnnpack as the default flavor (producing executorch-android without suffix) and updates the default version to 1.2.0-SNAPSHOT. This change aligns the main branch with the artifact naming modifications from PR #16806.

Changes:

  • Modified artifact naming logic to exclude the -xnnpack suffix, making it the default flavor
  • Updated default version from 1.0.0-SNAPSHOT to 1.2.0-SNAPSHOT

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kirklandsign kirklandsign merged commit fda6d51 into main Jan 27, 2026
152 of 158 checks passed
@kirklandsign kirklandsign deleted the copilot/update-gradle-version-to-120-snapshot branch January 27, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@shoumikhin shoumikhin shoumikhin approved these changes

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

Assignees

@kirklandsign kirklandsign

Copilot code review Copilot

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shoumikhin @kirklandsign